Incorporate OIT into MeshPipelineKey used by the LineGizmoPipeline #17946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweatherley
added
A-Rendering
IceSentry
approved these changes
Feb 20, 2025
IceSentry
added
the
D-Trivial
mweatherley
added
S-Ready-For-Final-Review
atlv24
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #17945
Solution
Check if the view being extracted has OIT enabled and incorporate the associated bit into the mesh pipeline key.
I basically have no idea what's going on in the renderer, so let me know if I missed something, which is extraordinarily possible.
Testing
I modified the
order_independent_transparencyexample to put everything on the default render layer and render a gizmo at the origin. Previously, this would cause the application to panic.