Skip to content

Add BundleRemover #18521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add BundleRemover #18521

wants to merge 9 commits into from
+432 −379

Conversation

ElliottjPierce
Copy link
Contributor

@ElliottjPierce ElliottjPierce commented Mar 24, 2025 •
edited
Loading

Objective

It has long been a todo item in the ecs to create a BundleRemover alongside the inserter, spawner, etc.

This is an uncontroversial first step of #18514.

Solution

Move existing code from complex helper functions to one generalized BundleRemover.

Testing

Existing tests.

@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Mar 24, 2025
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Unsafe Touches with unsafe code in some way labels Mar 24, 2025
@ElliottjPierce ElliottjPierce mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Unsafe Touches with unsafe code in some way S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@ElliottjPierce @alice-i-cecile