Fix generation of BIDS changelog #1835
Conversation
sappelhoff
added
the
exclude-from-changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1835 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 16 16
Lines 1380 1380
=======================================
Hits 1215 1215
Misses 165 165 ☔ View full report in Codecov by Sentry. |
| --enhancement-label "" \ | ||
| --bugs-label "" \ | ||
| --exclude-labels "exclude-from-changelog" | ||
| cat ~/changelog_build/CHANGES.md |
There was a problem hiding this comment.
I think we could start running the changelog generation and linting on every commit to master ... and then commit this as previously, only on "Merge commits" to master.
This would allow us to earlier find issues with generation and linting.
| head -n 100 ~/changelog_build/CHANGES.md | ||
| sed -i 's/* /- /' ~/changelog_build/CHANGES.md | ||
| head -n 100 ~/changelog_build/CHANGES.md | ||
| npx remark-cli ~/changelog_build/CHANGES.md --frail --rc-path ~/project/.remarkrc |
There was a problem hiding this comment.
|
getting confusing issues here. Perhaps it's time we updated github-changelog-generator to a newer version ... not the one from X years, as currently. So far we were blocked from doing that because of this issue: ... however, I think we can just ignore the |
|
it's really frustrating dealing with github tokens, there are too many, and none seem to work
I cannot find our |
sappelhoff
changed the title
|
replacing this PR with #1836 |
Note that these issues seem to have been present for months already, and we didn't catch them, unfortunately.