-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of BIDS changelog #1836
Conversation
dabe894
to
d27ce65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1836 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 16 16
Lines 1380 1380
=======================================
Hits 1215 1215
Misses 165 165 ☔ View full report in Codecov by Sentry. |
Okay, I am confident that this PR now fixes our changelog situation. I have tested the last stage (after a merge commit) also in https://github.com/sappelhoff/testing and everything runs as expected. All in all, this PR:
with this in place, we should have time to tackle a migration of the changelog generation as discussed in: ... without stressing over it. |
Replaces #1835, so that this is a PR not from a fork, but from the org itself.
This is an attempt to work around the "Pass secrets to builds from forked pull requests" CircleCI setting, which we'd rather leave "switched off" for security reasons.
EDIT: will migrate this to GH actions, as discussed in maintainers meeting.
NOTE: authentification is working, but we run into secondary API limits, so the workflow may take a long time to run!
... mentioned in #1844