Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of BIDS changelog #1836

Merged
merged 18 commits into from
Jun 1, 2024
Merged

Fix generation of BIDS changelog #1836

merged 18 commits into from
Jun 1, 2024

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented May 24, 2024

Replaces #1835, so that this is a PR not from a fork, but from the org itself.

This is an attempt to work around the "Pass secrets to builds from forked pull requests" CircleCI setting, which we'd rather leave "switched off" for security reasons.

EDIT: will migrate this to GH actions, as discussed in maintainers meeting.

NOTE: authentification is working, but we run into secondary API limits, so the workflow may take a long time to run!

... mentioned in #1844

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (124ac21) to head (2eb872e).
Report is 256 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files          16       16           
  Lines        1380     1380           
=======================================
  Hits         1215     1215           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label May 31, 2024
@sappelhoff
Copy link
Member Author

Okay, I am confident that this PR now fixes our changelog situation. I have tested the last stage (after a merge commit) also in https://github.com/sappelhoff/testing and everything runs as expected.

All in all, this PR:

  1. moves the changelog generation from circleci to GH actions
  2. updates the changelog generation software to a newer version
  3. fixes the ensuing bugs that were previously uncaught

with this in place, we should have time to tackle a migration of the changelog generation as discussed in:

... without stressing over it.

@sappelhoff sappelhoff merged commit be50185 into master Jun 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants