Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for sequenza (414-2) #436

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

ericblanc20
Copy link
Contributor

Add sequenza as a copy number caller, instead of bundling within the homologous_recombination_deficiency step.

Advantages:

  • Cleaner code
  • scarHRD relies on an obsolete version of sequenza which returns NA for average coverage.
  • The ploidy & purity values can be extracted without relying on scarHRD
  • Access to the full sequenza report (potentially, as it isn't implemented yet)

@ericblanc20 ericblanc20 requested a review from mbenary August 30, 2023 12:53
@ericblanc20 ericblanc20 changed the title 414 2 sequenza feat: added support for sequenza (414-2) Aug 30, 2023
@@ -120,7 +121,7 @@
# Default configuration somatic_targeted_seq_cnv_calling
step_config:
somatic_targeted_seq_cnv_calling:
tools: ['cnvkit'] # REQUIRED - available: 'cnvkit', 'copywriter', 'cnvetti_on_target' and 'cnvetti_off_target'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is copywriter removed as an option? The parameters are still around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change & keep copywriter in the list. All the code is there anyway, and might still be functional, except that CopywriteR is not in bioconductor/bioconda.

-gc {snakemake.input.gc} --fasta {genome} \
-n {snakemake.input.normal_bam} --tumor {snakemake.input.tumor_bam} \
-C {contigs} {extra_arguments} \
| sequenza-utils seqz_binning -s - \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "-s -" correct for the piping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is, -s means that a seqz file is expected, and - means /dev/stdin

@github-actions
Copy link

  • Please format your Python code with black: make black
  • Please format your Snakemake code with snakefmt: make snakefmt
  • Please organize your imports isorts: make isort
  • Please ensure that your code passes flake8: make flake8

You can trigger all lints locally by running make lint

@ericblanc20 ericblanc20 merged commit c1a215e into 414-defining-tumor-purityploidy Aug 30, 2023
@ericblanc20 ericblanc20 deleted the 414-2-sequenza branch August 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants