Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: supply pre-commit-hooks and replace flake8+isort+black with ruff #497

Closed
wants to merge 6 commits into from

Conversation

tedil
Copy link
Member

@tedil tedil commented Apr 4, 2024

A bit of a spring-cleaning PR:

  1. provides a pre-commit hook configuration file which runs linting and formatting on git commit.
  2. replaces the trinity of flake8, isort and black with ruff
  3. fixed lints and re-formatted with ruff, which is why so many files are modified.

I initially only wanted to add the pre-commit hooks, but ... well, here we are, with 263 files modified due to formatting/lint fixes.

Copy link

github-actions bot commented Apr 4, 2024

  • Please format your Python code with black: make black
  • Please format your Snakemake code with snakefmt: make snakefmt
  • Please organize your imports isorts: make isort
  • Please ensure that your code passes flake8: make flake8

You can trigger all lints locally by running make lint

@tedil tedil marked this pull request as ready for review April 4, 2024 16:00
@coveralls
Copy link

Coverage Status

coverage: 85.775% (+0.03%) from 85.742%
when pulling becdbba on pre-commit-hooks-and-ruff
into af961cc on main.

@tedil tedil marked this pull request as draft April 16, 2024 12:35
@tedil
Copy link
Member Author

tedil commented Jun 28, 2024

superseded by #496

@tedil tedil closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants