Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set locale to C in bcftools/TMB wrapper #507

Merged
merged 1 commit into from
May 6, 2024

Conversation

tedil
Copy link
Member

@tedil tedil commented Apr 30, 2024

When the user's locale was set to one that uses , instead of . as a decimal point, the wrapper would fail.

@tedil tedil requested a review from giacuong171 April 30, 2024 09:32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ericblanc20 ericblanc20 merged commit 9789a2d into main May 6, 2024
7 checks passed
@ericblanc20 ericblanc20 deleted the fix-tmb-printf-locale branch May 6, 2024 16:47
@tedil tedil mentioned this pull request Jun 28, 2024
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants