Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: utility snappy wrapper class for code deduplication #583

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

tedil
Copy link
Member

@tedil tedil commented Dec 13, 2024

No description provided.

Copy link

  • Please format your Python code with ruff: make fmt
  • Please check your Python code with ruff: make check
  • Please format your Snakemake code with snakefmt: make snakefmt

You can trigger all lints locally by running make lint

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 85.77%. remained the same
when pulling e986d12 on add-simple-wrapper
into 42d2c01 on main.

@ericblanc20 ericblanc20 marked this pull request as ready for review December 13, 2024 14:55
Copy link
Contributor

@ericblanc20 ericblanc20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe just change R --vanilla < {snakemake.output.script} to Rscript --vanilla {snakemake.output.script}

@tedil tedil merged commit 4a6c2ec into main Dec 13, 2024
7 checks passed
@tedil tedil deleted the add-simple-wrapper branch December 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants