-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Rust 1.80.0 #3584
Conversation
5ca6af6
to
a741134
Compare
@@ -72,11 +72,11 @@ type JsonRpcResult = Result<Box<RawValue>, TransportError>; | |||
/// This structs holds an instance of the `tokio` runtime, as well as the | |||
/// following fields: | |||
/// - `write_send` is a sender handle to the "write channel", an MPSC channel | |||
/// that's used to queue up requests to be sent to the server (for simplicity | |||
/// the requests are pushed to the channel as serialized byte buffers) | |||
/// that's used to queue up requests to be sent to the server (for simplicity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering: does the rule require 4 spaces? Or 2 spaces could be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two spaces. I used the tab to be fast
a741134
to
fb4cee4
Compare
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #3584 will degrade performances by 7.69%Comparing Summary
Benchmarks breakdown
|
Summary
Test Plan