Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Rust 1.80.0 #3584

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore: upgrade to Rust 1.80.0 #3584

merged 1 commit into from
Aug 5, 2024

Conversation

ematipico
Copy link
Member

Summary

Test Plan

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis labels Aug 4, 2024
@ematipico ematipico requested review from a team August 4, 2024 13:35
@@ -72,11 +72,11 @@ type JsonRpcResult = Result<Box<RawValue>, TransportError>;
/// This structs holds an instance of the `tokio` runtime, as well as the
/// following fields:
/// - `write_send` is a sender handle to the "write channel", an MPSC channel
/// that's used to queue up requests to be sent to the server (for simplicity
/// the requests are pushed to the channel as serialized byte buffers)
/// that's used to queue up requests to be sent to the server (for simplicity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering: does the rule require 4 spaces? Or 2 spaces could be enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spaces. I used the tab to be fast

Copy link
Contributor

github-actions bot commented Aug 4, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48452 48452 0
Passed 47255 47255 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.53% 97.53% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6551 6551 0
Passed 2199 2199 0
Failed 4352 4352 0
Panics 0 0 0
Coverage 33.57% 33.57% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18333 18333 0
Passed 14026 14026 0
Failed 4307 4307 0
Panics 0 0 0
Coverage 76.51% 76.51% 0.00%

Copy link

codspeed-hq bot commented Aug 4, 2024

CodSpeed Performance Report

Merging #3584 will degrade performances by 7.69%

Comparing chore/update-rust (fb4cee4) with main (75b1ac5)

Summary

❌ 1 regressions
✅ 103 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chore/update-rust Change
react.production.min_3378072959512366797.js[cached] 1.8 ms 2 ms -7.69%

@ematipico ematipico merged commit 98deae6 into main Aug 5, 2024
15 of 16 checks passed
@ematipico ematipico deleted the chore/update-rust branch August 5, 2024 11:53
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants