Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Rust 1.80.0 #3584

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/biome_analyze/src/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ impl<L: Language> RegistryVisitor<L> for MetadataRegistry {
/// we have:
/// - Syntax Phase: No services are offered, thus its rules can be run immediately;
/// - Semantic Phase: Offers the semantic model, thus these rules can only run
/// after the "SemanticModel" is ready, which demands a whole transverse of the parsed tree.
/// after the "SemanticModel" is ready, which demands a whole transverse of the parsed tree.
pub struct RuleRegistry<L: Language> {
/// Holds a collection of rules for each phase.
phase_rules: [PhaseRules<L>; 2],
Expand Down
16 changes: 8 additions & 8 deletions crates/biome_cli/src/service/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ type JsonRpcResult = Result<Box<RawValue>, TransportError>;
/// This structs holds an instance of the `tokio` runtime, as well as the
/// following fields:
/// - `write_send` is a sender handle to the "write channel", an MPSC channel
/// that's used to queue up requests to be sent to the server (for simplicity
/// the requests are pushed to the channel as serialized byte buffers)
/// that's used to queue up requests to be sent to the server (for simplicity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering: does the rule require 4 spaces? Or 2 spaces could be enough?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spaces. I used the tab to be fast

/// the requests are pushed to the channel as serialized byte buffers)
/// - `pending_requests` is handle to a shared hashmap where the keys are `u64`
/// corresponding to request IDs, and the values are sender handles to oneshot
/// channel instances that can be consumed to fulfill the associated request
/// corresponding to request IDs, and the values are sender handles to oneshot
/// channel instances that can be consumed to fulfill the associated request
///
/// Creating a new `SocketTransport` instance requires providing a `tokio`
/// runtime instance as well as the "read half" and "write half" of the socket
Expand All @@ -87,12 +87,12 @@ type JsonRpcResult = Result<Box<RawValue>, TransportError>;
///
/// This concurrent handling of I/O is implemented useing two "background tasks":
/// - the `write_task` pulls outgoing messages from the "write channel" and
/// writes them to the "write half" of the socket
/// writes them to the "write half" of the socket
/// - the `read_task` reads incoming messages from the "read half" of the
/// - the `read_task` reads incoming messages from the "read half" of the
/// socket, then looks up a request with an ID corresponding to the received
/// message in the "pending requests" map. If a pending request is found, it's
/// fulfilled with the content of the message that was just received
/// socket, then looks up a request with an ID corresponding to the received
/// message in the "pending requests" map. If a pending request is found, it's
/// fulfilled with the content of the message that was just received
///
/// In addition to these, a new "foreground task" is created for each request.
/// Each foreground task creates a oneshot channel and stores it in the pending
Expand Down
2 changes: 1 addition & 1 deletion crates/biome_configuration/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ biome_graphql_analyze = { workspace = true }
biome_graphql_syntax = { workspace = true }
biome_js_analyze = { workspace = true }
biome_js_formatter = { workspace = true, features = ["serde"] }
biome_js_syntax = { workspace = true, features = ["serde", "schema"] }
biome_js_syntax = { workspace = true, features = ["schema"] }
biome_json_analyze = { workspace = true }
biome_json_formatter = { workspace = true, features = ["serde"] }
biome_json_parser = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion crates/biome_css_syntax/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ version = "0.5.7"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
biome_rowan = { workspace = true }
biome_rowan = { workspace = true, features = ["serde"] }
schemars = { workspace = true, optional = true }
serde = { workspace = true, features = ["derive"] }

Expand Down
Loading
Loading