-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: math lib is not linked in linux #2
base: main
Are you sure you want to change the base?
Conversation
@@ -3,7 +3,7 @@ package sdk | |||
import ( | |||
"encoding/json" | |||
|
|||
"github.com/bitwarden/sdk-go/internal/cinterface" | |||
"github.com/mattscamp/sdk-go/internal/cinterface" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You left in the module rewrites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof. Thought I pushed this to a different branch. Will fix ASAP.
Hey @mattscamp, thanks for the PR! This repository is just used for publishing the Go library, but it is a read only mirror of the sdk monorepo, the changes from this PR should instead go on this file here: https://github.com/bitwarden/sdk/blob/main/languages/go/internal/cinterface/bitwarden_library.go Would you mind opening a PR there instead? Thanks! |
|
Created PR here bitwarden/sdk-sm#1120 |
The math lib is used upstream and not linked properly. This causes the below failures on linux.