[PM-12431] Temporarily un-export bitwarden_fido #1072
Merged
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Hinton
requested changes
Sep 23, 2024
Hinton
approved these changes
Sep 26, 2024
Hey @coroiu, yes, lots of build errors 😅 Please see the PR description |
vgrassia
approved these changes
Sep 26, 2024
coltonhurst
added a commit
that referenced
this pull request
Sep 26, 2024
coltonhurst
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12431
📔 Objective
Temporarily un-export
bitwarden-fido. We can't release crates for1.0because:bitwarden-fidocurrently relies on dependencies that are GitHub repositories (reference)bitwarden-fidois not yet released (same with the aforementioned dependencies)This PR also includes the auto-updates to the
Cargo.lock file, which should be fine.⭐️NOTE⭐️: This will break CI, this should only be merged when we are ready to do 1.0 releases of
bitwarden,bws, etc. It should quickly be followed up a PR, after release, which reverses this.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes