Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12431] Re-export bitwarden_fido #1073

Closed
wants to merge 1 commit into from
Closed

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Sep 20, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12431

📔 Objective

Undo the changes after the 1.0 releases introduced and explained here: #1072

The PR targets pm/pm-12431 as the base, which should be automatically updated by GitHub to main once the breaking PR is merged first.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details5c688838-e466-4726-9048-b612bac9fa09

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pm/pm-12431@8a2c647). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             pm/pm-12431    #1073   +/-   ##
==============================================
  Coverage               ?   58.12%           
==============================================
  Files                  ?      197           
  Lines                  ?    13532           
  Branches               ?        0           
==============================================
  Hits                   ?     7865           
  Misses                 ?     5667           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coltonhurst coltonhurst changed the base branch from main to pm/pm-12431 September 20, 2024 19:42
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing to stop notifications :)

@coltonhurst
Copy link
Member Author

Closing as we will use the GitHub "revert" functionality instead of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants