Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login username to fido2 name fallback #857

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Jun 25, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Add LoginView.username to user_name_for_ui in Fido2CredentialAutofillView

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 2e324642-be63-4e1a-b485-4f7a206b35ab

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (aa3600d) to head (9c680db).

Files Patch % Lines
crates/bitwarden-fido/src/types.rs 0.00% 4 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   59.20%   59.18%   -0.02%     
==========================================
  Files         192      192              
  Lines       12581    12585       +4     
==========================================
  Hits         7449     7449              
- Misses       5132     5136       +4     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@coroiu coroiu merged commit ef86ab9 into main Jun 25, 2024
104 checks passed
@coroiu coroiu deleted the fix-fido2-name-fallback branch June 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants