-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVOPS-1333] Add code signing to the macOS bws CLI #535
[DEVOPS-1333] Add code signing to the macOS bws CLI #535
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 59.40% 59.40%
=======================================
Files 171 171
Lines 10345 10345
=======================================
Hits 6145 6145
Misses 4200 4200 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the lint job is also failing, it can be fixed with prettier.
https://github.com/bitwarden/sdk/actions/runs/7843907208/job/21405205913#step:9:16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Objective
Code changes
Before you submit