Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert README for 0.5.0 #784

Merged
merged 1 commit into from
Jul 8, 2024
Merged

revert README for 0.5.0 #784

merged 1 commit into from
Jul 8, 2024

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Apr 23, 2024

🚀 Pull Request

Description

This pull-request aligns the examples within the README.md with main and the forthcoming geovista.pantry module reorganisation breaking change.

This pull-request must be merged prior to the 0.5.0 release.

Until then it will remain in draft 👍

Reference #783 and #782


@github-actions github-actions bot added the type: infrastructure Auto-labelled label Apr 23, 2024
@bjlittle bjlittle marked this pull request as draft April 23, 2024 09:33
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (f826f2c) to head (4490621).
Report is 140 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          58       58           
  Lines        2934     2934           
=======================================
  Hits         2679     2679           
  Misses        255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle
Copy link
Owner Author

bjlittle commented Jun 12, 2024

@trexfeathers You should be aware of this pull request given #826.

The code in the README.md should work for the latest release and not the main branch, as it initially confused users.

The plan is to merge this pull request just prior to releasing 0.5.0, then the world's will align again.

@bjlittle bjlittle force-pushed the revert-readme-v0p5p0 branch from c128e85 to 8968d60 Compare July 8, 2024 05:52
@bjlittle bjlittle marked this pull request as ready for review July 8, 2024 05:53
@bjlittle bjlittle force-pushed the revert-readme-v0p5p0 branch from 8968d60 to e8e47cd Compare July 8, 2024 06:13
@bjlittle bjlittle force-pushed the revert-readme-v0p5p0 branch from e8e47cd to a60009d Compare July 8, 2024 06:27
@bjlittle bjlittle force-pushed the revert-readme-v0p5p0 branch from a60009d to 4490621 Compare July 8, 2024 16:22
@bjlittle bjlittle merged commit 25978d9 into main Jul 8, 2024
23 checks passed
@bjlittle bjlittle deleted the revert-readme-v0p5p0 branch July 8, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

1 participant