Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various README suggestions #826

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

trexfeathers
Copy link
Collaborator

🚀 Pull Request

Description

Updating dead links, out-dated code, and a couple of other suggestions


@trexfeathers trexfeathers added the type: documentation Auto-labelled for doc/* and docs/* branches label Jun 12, 2024
@trexfeathers trexfeathers requested a review from bjlittle as a code owner June 12, 2024 18:31
@github-actions github-actions bot added the type: infrastructure Auto-labelled label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (ef4dc5a) to head (9d551ff).
Report is 247 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #826   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          58       58           
  Lines        2939     2939           
=======================================
  Hits         2680     2680           
  Misses        259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle mentioned this pull request Jun 12, 2024
Copy link
Owner

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers Awesome, thanks! 🍻

It's great having a fresh pair of 👀 on this.

A couple of comments to service, then we can bank your improvements.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bjlittle bjlittle enabled auto-merge (squash) June 14, 2024 13:08
@bjlittle bjlittle merged commit a87396f into bjlittle:main Jun 14, 2024
23 checks passed
@trexfeathers
Copy link
Collaborator Author

Thanks @bjlittle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Auto-labelled for doc/* and docs/* branches type: infrastructure Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants