fix: check for duplicate configs and secrets within a module #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
The original issue was just about preventing duplicates in the schema, not necessarily in the code. I think this makes sense though, as it's a bit of a code smell to redeclare something in multiple locations. |
alecthomas
approved these changes
Apr 24, 2024
go-runtime/compile/schema.go
Outdated
| for _, d := range pctx.module.Decls { | ||
| c, ok := d.(*schema.Config) | ||
| if ok && c.Name == name && c.Type.String() == st.String() { | ||
| pctx.errors.add(errorf(node, "duplicate config declaration")) |
There was a problem hiding this comment.
Let's report the location of the other declaration in the message (here and below).
|
You'll need to roll this out to the PFI repo, which will be ... interesting. |
|
Notes to self (and anyone curious :) )
|
|
Don't delay merges, just get them in. |
|
Got it, sounds good! I'll merge this to start (once everything passes) and get the rest of it done in a following PR. I'll move my TODOs to the issue for better tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to one part of #1121