Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/Launchpad with view & add buttons - PRESS4 509 #1023

Merged
merged 17 commits into from
Apr 18, 2024
Merged

feature/Launchpad with view & add buttons - PRESS4 509 #1023

merged 17 commits into from
Apr 18, 2024

Conversation

manikantakailasa
Copy link
Contributor

We will have a pages menu item
And there will be launchpads for each public content type
And there will be lanchpads for each public custom content type
And there will be a "view all" option for each type
And there will be an "add new" option for each type

story - https://jira.newfold.com/browse/PRESS4-509

@wpalani
Copy link
Member

wpalani commented Apr 15, 2024

Thanks, @manikantakailasa, for opening this PR. Here are some items I noticed while reviewing the code/UI:

  • There appears to be an extra border or shadow around some of the UI boxes that are throwing off the UI.
    ext-border
  • UI needs a mobile breakpoint similar to other pages in the app. Please look at other pages/components to see how the responsiveness is handled.
  • Products box needs to check if WooCommerce is active before displaying it. Now, the links on it go to an invalid post type page when clicked on while WooCommerce is not present.
  • Booking and Appointments box needs to check if WooCommerce is active in addition to the Yith plugin before displaying it. Now, the links on it go to an invalid post type page when clicked on while WooCommerce is not present.
  • pagesAndPosts/index.js has /* eslint-disable prettier/prettier */ comment on top which disables eslint/prettier this needs to be removed and the component needs to be linted properly.
  • Reslove outstanding merge conflicts.
  • Please write Cypress tests for the new page/UI.
  • Less important: the root package.json file spacing appears to be changed from tabs/4 to spaces/2. Please fix for consistency.

@wpalani wpalani requested review from wpalani and wpscholar April 15, 2024 20:14
@ramyakrishnai ramyakrishnai changed the base branch from develop to PRESS4-509 April 18, 2024 06:07
@ramyakrishnai ramyakrishnai merged commit 95c8905 into bluehost:PRESS4-509 Apr 18, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants