Add/features module #1067
Merged
Add/features module #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add features to runtime and adjust menus accordingly
* develop: (25 commits) Composer(deps): Bump newfold-labs/wp-module-notifications Reorg deps Add notification with 'bluehost-app-nav' context in the app nav Composer(deps): Bump newfold-labs/wp-module-activation Composer(deps): Bump newfold-labs/wp-module-performance updating lock files Rename test file name Remove facebook module from composer packages fix border styles Change launchpad page slug ecommerce version bump to 1.3.28 bug fixes fixing cypress test error cypress tests added coments addresed runtime version update and eslint fix update to products and desc lock files storepage redirection urls ... # Conflicts: # composer.json # composer.lock # inc/Admin.php
* main: Updated tested up to wp version Bump deactivation module 1.1.2 update wordpress versions in cypress matrix Skip ecomm tests when the env is less than wp 6.4 Bump npm package version Resolve conflicts Fix tests Fix tests update lock file Update Onboarding to 2.3.0 update ecommerce version bump and lock files updated Bump ecommerce npm package Bump version bump ecommerce, onboarding and patterns modules # Conflicts: # composer.json # composer.lock
* main: bump version in package file too bump plugin version to 3.10.2 composer bump Update dependencies Update Onboarding to 2.3.1
2 failed and 1 flaky tests on run #8426 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin |
Test Replay
Screenshots
Video
|
|
Store/storePage.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Commerce Home Page- Next Steps > Verify Next steps when experience level is novice |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #1067 ↗︎
also adds a `featureToggle` helper method to interface with the feature API
* develop: (23 commits) fixing linting resolved conflicts ecommerce version bump 1.3.31 update lock files lock file update update lock files added translation added translations updated lock files updating the class name to social update lock files eslint fix package.json update updated facebook changes lock files remove auto reload fix:imports align items to center fix:fb color plugin view fb connect ... # Conflicts: # composer.json # composer.lock # src/app/pages/settings/index.js
1.9.0 is used in place of a 2.0.0 release for patterns and performance modules since the 1.x version is a cross-dependency for onboarding/onboarding-data modules.
but always display on admin page
* develop: Update lock file Update Onboarding to 2.3.2 # Conflicts: # composer.json # composer.lock
both as 1.9.9 since onboarding still requires 1.x versions of each module
2 failed and 1 flaky tests on run #8425 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin |
Test Replay
Screenshots
Video
|
|
Store/storePage.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Commerce Home Page- Next Steps > Verify Next steps when experience level is novice |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #1067 ↗︎
wpalani
approved these changes
May 29, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds the features module and updates the staging and performance module to integrate with the features module. Their initialization now uses the features setup according to the platform context.
Type of Change
Checklist
Further comments