bug/url changes for events and webinars - PRESS0-1282 #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug/url changes for events and webinars - PRESS0-1282
ramyakrishnai
changed the title
|
created this PR to run all the tests #1076 |
1 failed and 1 flaky tests on run #8352 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Help Page > Is Accessible |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Commerce Home Page- Next Steps > Verify Next steps when experience level is novice |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #1077 ↗︎
2 failed and 1 flaky tests on run #8429 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Verify Wondercart accessibility as per site capabilities > Verify clicking Install Now successfully installs Wonder Cart plugin |
Test Replay
Screenshots
Video
|
|
Store/storePage.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Store Page- WooCommerce is deactivated/uninstalled > Verify that Payments tab is not displayed |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Commerce Home Page- Next Steps > Verify Next steps when experience level is novice |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #1077 ↗︎
|
I think ideally we leave those utm query parameters in the url. |
updated with utm query params |
circlecube
approved these changes
May 20, 2024
|
@ramyakrishnai Can you resolve the conflicts please? |
* develop: (25 commits) remove unused icon for route update performance and patterns modules to 2.0.0 releases update help and staging modules to 2.0 releases only show help center toggle on settings if not locked use error state and eslint cleanup composer updates to require branches as versions copy updates for new toggles and clean up admin page Update lock file Update Onboarding to 2.3.2 add app admin page with feature toggles add feature toggles to settings page for help center and wonder blocks update atomic, context, features modules update feature module update feature module add atomic module update features module update features module to 1.1.1 lint load required files in modules properly update to released version of features module ... # Conflicts: # composer.lock
wpalani
approved these changes
May 29, 2024
tests/cypress/integration/help.cy.js
Outdated
| @@ -26,7 +26,7 @@ describe( 'Help Page', function () { | |||
| } ); | |||
|
|
|||
| it( 'Is Accessible', () => { | |||
| cy.checkA11y( '.wppbh-app-body' ); | |||
| cy.checkA11y( '.wppbh-app-body' , {timeout : 20000 }); | |||
There was a problem hiding this comment.
@ramyakrishnai Why do we have a 20sec delay? I'm not sure it's needed and it'll slow down our matrix runs.
There was a problem hiding this comment.
Test case was failing even after having the id tag in Dom so added delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update "Events and Webinars" from the redirecting to a 404 page. Instead take the end customer to;
https://www.bluehost.com/blog/events/
story : https://jira.newfold.com/browse/PRESS0-1282
Type of Change
Checklist
Further comments