Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/url changes for events and webinars - PRESS0-1282 #1077

Merged
merged 10 commits into from
May 29, 2024
Merged

bug/url changes for events and webinars - PRESS0-1282 #1077

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
daef06a
url change events and webinars
manikantakailasa May 16, 2024
7b324f0
Merge pull request #1076 from manikantakailasa/PRESS0-1282
ramyakrishnai May 16, 2024
0f73f2e
Merge branch 'develop' into update/help-center-links
ramyakrishnai May 17, 2024
79eebd2
lock changes and added timeout
ramyakrishnai May 17, 2024
729e193
Merge branch 'develop' into update/help-center-links
ramyakrishnai May 20, 2024
1a95534
added utm params
ramyakrishnai May 20, 2024
c47e314
Merge branch 'develop' into update/help-center-links
ramyakrishnai May 29, 2024
78da88e
lock updated
ramyakrishnai May 29, 2024
e00c07e
Merge branch 'develop' into update/help-center-links
circlecube May 29, 2024
180c30e
remove help test timeout
circlecube May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/app/data/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const help = [
),
icon: false,
cta: __( 'More Info', 'wp-plugin-bluehost' ),
url: 'https://www.bluehost.com/learn/?utm_campaign=&utm_content=help_blog_link&utm_term=learn_stuff&utm_medium=brand_plugin&utm_source=wp-admin/admin.php?page=bluehost#/help',
url: 'https://www.bluehost.com/blog/events/?utm_campaign=&utm_content=help_blog_link&utm_term=learn_stuff&utm_medium=brand_plugin&utm_source=wp-admin',
},
{
name: 'website',
Expand Down
2 changes: 1 addition & 1 deletion tests/cypress/integration/help.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe( 'Help Page', function () {
} );

it( 'Is Accessible', () => {
cy.checkA11y( '.wppbh-app-body' );
cy.checkA11y( '.wppbh-app-body' , {timeout : 20000 });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramyakrishnai Why do we have a 20sec delay? I'm not sure it's needed and it'll slow down our matrix runs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case was failing even after having the id tag in Dom so added delay.

} );

it( 'Phone Card Exists', () => {
Expand Down
Loading