Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Sales Channel route under Store main menu item #1169

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Adding Sales Channel route under Store main menu item #1169

merged 2 commits into from
Jul 24, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

JIRA: https://jira.newfold.com/browse/PRESS0-1480

  • To improve the visibility of the EcomDash plugin to our Ecommerce plus customers.
  • If a customer has the Ecomdash entitlement, then the customer should see the Ecomdash landing page from the Store navigation under "Sales Channels".
  • When a customer clicks on the page the first time, the CTA Get Started, it should open a new window with the Ecomdash onboarding.
  • After a customer has setup the Ecomdash plugin, the customer should see the landing page with Open Dashboard as the CTA instead of the Get Started CTA.
  • Related Ecommerce module PR
  • Figma

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 changed the base branch from main to develop July 4, 2024 14:50
@aratidgr8 aratidgr8 mentioned this pull request Jul 4, 2024
Merged
8 tasks
@cypress Cypress
Copy link

cypress bot commented Jul 4, 2024 •
edited
Loading

Passing run #9132 ↗︎

0 391 59 0 Flakiness 0

Details:

Merge 12fd422 into 10be404...
Project: Bluehost Brand Plugin Commit: 032645e7b9 ℹ️
Status: Passed Duration: 24:37 💡
Started: Jul 12, 2024 9:10 AM Ended: Jul 12, 2024 9:35 AM

Review all test suite changes for PR #1169 ↗︎

@wpscholar wpscholar added this to the July 17 Release milestone Jul 5, 2024
@wpalani wpalani self-requested a review July 8, 2024 22:49
wpalani
wpalani approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@wpalani wpalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There's a minor linting problem, do you mind addressing it before merging?

@wpalani
Copy link
Member

wpalani commented Jul 11, 2024

Looks good. There's a minor linting problem, do you mind addressing it before merging?

@aratidgr8 Checking if you had a chance to fix the lint issue?

@aratidgr8
Copy link
Contributor Author

@wpalani sorry not sure how I missed on this comment. Apologies, will fix it ASAP.

@ramyakrishnai ramyakrishnai changed the base branch from develop to feature/PRESS0-1480 July 12, 2024 09:07
@ramyakrishnai ramyakrishnai changed the base branch from feature/PRESS0-1480 to develop July 12, 2024 09:07
@aratidgr8
Copy link
Contributor Author

@wpalani Lint fixes are done.
@wpscholar there is a related PR in Ecommerce module for which QA & code review signoff are pending. Request you to not to merge this PR in 17th July release.
Thanks!

@wpalani
Copy link
Member

wpalani commented Jul 17, 2024

@wpalani Lint fixes are done. @wpscholar there is a related PR in Ecommerce module for which QA & code review signoff are pending. Request you to not to merge this PR in 17th July release. Thanks!

@aratidgr8
I see that your other PR in the e-commerce module is still open. Pushing this to the July 31 milestone.

@chrisdavidmiles
Copy link
Contributor

pre-login

@chrisdavidmiles
Copy link
Contributor

post-login

@wpalani wpalani merged commit c04664e into develop Jul 24, 2024
3 of 5 checks passed
@wpalani wpalani deleted the PRESS0-1480 branch July 24, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpalani wpalani wpalani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.0 - July 31 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@aratidgr8 @wpalani @chrisdavidmiles @wpscholar @ramyakrishnai