Add Sales channel page to promote Ecomdash plugin adoption #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aratidgr8
changed the title
Merged
8 tasks
aratidgr8
changed the title
src/components/SalesChannel.js
Outdated
| className="nfd-button nfd-button--primary" | ||
| variant="primary" | ||
| type="button" | ||
| as={ canAccessGlobalCTB ? hasEcomdash ? ecomdashStatus.data.isInstalled ? "a" : "button" : "button" : null } |
There was a problem hiding this comment.
can we make it this way for better readability
Suggested change
| as={ canAccessGlobalCTB ? hasEcomdash ? ecomdashStatus.data.isInstalled ? "a" : "button" : "button" : null } | |
| as={ canAccessGlobalCTB ? ( hasEcomdash ? ( ecomdashStatus.data.isInstalled ? "a" : "button" ) : "button" ) : null } |
src/components/SalesChannel.js
Outdated
| ) : null} | ||
| id={ecomdashStatus.data.isInstalled ? "manage-ecomdash" : "install-ecomdash" } | ||
| > | ||
| {ecomdashStatus.data.isInstalled ? ecomdashSetupStatus ? __("Get Started Now", "wp-module-ecommerce") : __("Go to Ecomdash", "wp-module-ecommerce") : __("Get Started Now", "wp-module-ecommerce") } |
There was a problem hiding this comment.
Suggested change
| {ecomdashStatus.data.isInstalled ? ecomdashSetupStatus ? __("Get Started Now", "wp-module-ecommerce") : __("Go to Ecomdash", "wp-module-ecommerce") : __("Get Started Now", "wp-module-ecommerce") } | |
| {ecomdashStatus.data.isInstalled ? ( ecomdashSetupStatus ? __("Get Started Now", "wp-module-ecommerce") : __("Go to Ecomdash", "wp-module-ecommerce") ) : __("Get Started Now", "wp-module-ecommerce") } |
There was a problem hiding this comment.
@ramyakrishnai As discussed, button label when in to be installed state will be Install now
src/components/SalesChannel.js
Outdated
| <span className="nfd-flex-1 nfd-text-[#4A5567] nfd-leading-5 nfd-font-medium"> | ||
| {__("Accurately sync kits, multipacks, and components without any headaches.", "wp-module-ecommerce")} | ||
| <br /> | ||
| {__("headaches.", "wp-module-ecommerce")} |
There was a problem hiding this comment.
is this expected, as we already have one in above line as well.
src/components/SalesChannel.js
Outdated
| <div className="nfd-text-[#000000] nfd-leading-5 nfd-font-medium nfd-mt-5 nfd-mb-11"> | ||
| {__("Print barcodes for your products that can be", "wp-module-ecommerce")} | ||
| <br /> | ||
| {__("used for labedivng and scanning your", "wp-module-ecommerce")} |
There was a problem hiding this comment.
is this a spelling mistake labeling.
| {__("Print shipping labels with a preferred carrier right from your ecomdash account and save on postage.", "wp-module-ecommerce")} | ||
| <br /> | ||
| {__("right from your ecomdash account and save", "wp-module-ecommerce")} | ||
| <br /> |
There was a problem hiding this comment.
these needs to be removed either from the above line or from here
right from your ecomdash account and save on postage.
src/components/SalesChannel.js
Outdated
| <br /> | ||
| {__("the manual data entry needed when creating", "wp-module-ecommerce")} | ||
| <br /> | ||
| {__("new listings.", "wp-module-ecommerce")} |
There was a problem hiding this comment.
these lines are written twice
ramyakrishnai
previously approved these changes
Jul 16, 2024
src/components/SalesChannel.js
Outdated
| @@ -113,7 +117,7 @@ export function SalesChannel(props) { | |||
| ) : null} | |||
| id={ecomdashStatus.data.isInstalled ? "manage-ecomdash" : "install-ecomdash"} | |||
| > | |||
| {ecomdashStatus.data.isInstalled ? (ecomdashSetupStatus ? __("Get Started Now", "wp-module-ecommerce") : __("Go to Ecomdash", "wp-module-ecommerce")) : __("Install Now", "wp-module-ecommerce")} | |||
| {ecomdashStatus.data.isInstalled ? (ecomdashLoading ? <><Spinner /> __("Loading...", "wp-module-ecommerce") </> : ecomdashSetupStatus ? __("Get Started Now", "wp-module-ecommerce") : __("Go to Ecomdash", "wp-module-ecommerce")) : __("Install Now", "wp-module-ecommerce")} | |||
There was a problem hiding this comment.
add a parenthisis for double ternary operation for better readablity
ramyakrishnai
approved these changes
Jul 24, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
JIRA: https://jira.newfold.com/browse/PRESS0-1480
Type of Change
Checklist
Further comments