Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up plugin code to pass phpcs checks #852

Closed

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Dec 5, 2023

Proposed changes

Updates the codebase to pass code standards and linting from #851.

Branched off and targeted towards feature/code-standards.

Copy link

cypress bot commented Dec 5, 2023

34 failed and 1 flaky tests on run #5940 ↗︎

34 211 57 0 Flakiness 1

Details:

Fix removed composer deps
Project: Bluehost Brand Plugin Commit: e2c7ac882a
Status: Failed Duration: 19:20 💡
Started: Dec 6, 2023 7:04 PM Ended: Dec 6, 2023 7:24 PM
Failed  tests/cypress/integration/navigation.cy.js • 2 failed tests

View Output Video

Test Artifacts
Navigation > Main nav links properly navigates Test Replay Screenshots Video
Navigation > Subnav links properly navigates Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ctb/tests/cypress/integration/ctb.cy.js • 3 failed tests

View Output Video

Test Artifacts
Click to buy > Button has CTB Attributes Test Replay Screenshots Video
Click to buy > CTB modal is functional Test Replay Screenshots Video
Click to buy > CTB purchase functions properly Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-global-ctb/tests/cypress/integration/global-ctb.cy.js • 3 failed tests

View Output Video

Test Artifacts
Click to buy > Button has CTB Attributes Test Replay Screenshots Video
Click to buy > CTB modal is functional Test Replay Screenshots Video
Click to buy > CTB fallback is functional Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-marketplace/tests/cypress/integration/marketplace.cy.js • 9 failed tests

View Output Video

Test Artifacts
Marketplace Page > Exists Test Replay Screenshots Video
Marketplace Page > Is Accessible Test Replay Screenshots Video
Marketplace Page > Product grid has 4 items Test Replay Screenshots Video
Marketplace Page > First product card renders correctly Test Replay Screenshots Video
Marketplace Page > Second product card render correctly Test Replay Screenshots Video
Marketplace Page > CTA links have target=_blank Test Replay Screenshots Video
Marketplace Page > Category Tab Filters properly Test Replay Screenshots Video
Marketplace Page > Load more button loads more products Test Replay Screenshots Video
Marketplace Page > Category tabs update path Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-patterns/tests/cypress/integration/wonder-blocks.cy.js • 3 failed tests

View Output Video

Test Artifacts
Wonder Blocks > Wonder Blocks button opens modal Test Replay Screenshots Video
Wonder Blocks > Close buttons closes modal Test Replay Screenshots Video
Wonder Blocks > ESC button closes modal too Test Replay Screenshots Video

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Review all test suite changes for PR #852 ↗︎

@circlecube
Copy link
Member

Now that tests are passing on main, maybe we revisit this.

Even though merging main into these branches will be full of conflicts...

@circlecube circlecube marked this pull request as draft June 19, 2024 18:40
@bradp bradp force-pushed the feature/code-standards-cleanup branch from e2c7ac8 to d137095 Compare October 2, 2024 00:50
@bradp bradp changed the base branch from feature/code-standards to feature/code-standards-2 October 2, 2024 00:51
@bradp bradp marked this pull request as ready for review October 2, 2024 00:55
@bradp bradp closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants