Prevent user pref races #1576
Merged
Prevent user pref races #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
approved these changes
Sep 11, 2023
estrattonbailey
added a commit
that referenced
this pull request
Sep 12, 2023
…Actor * origin: Get rate limit ip correctly (#1577) Remove temp.upgradeRepoVersion (#1588) Fix getRepo `since` (#1579) Prevent user pref races (#1576) Feature: block lists (#1531) Enable appview proxy in dev-env full network (#1580) Increase timeline threshold (#1573) @atproto/[email protected] Fixes and updates to the preferences API (#1575) Remove legacy repo sync impl (#1570) Move fuzzy matcher to appview (#1566) @atproto/[email protected] Add personal-details user preference with birth date (#1565) enable granular perms for publish action (#1563) maintain feed order (#1559)
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Sep 26, 2023
prevent user pref races
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
prevent user pref races
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting racing updates to the
putPreferencesroute that would leave the table in an inconsistent state.This applies a row lock on the user's row in the
user_accounttable to ensure that these updates get linearized. This should be a short-held lock and will block other writes while it is held.This seemed like the simplest implementation to prevent conflicting writes. Other options include:
UPDATE