-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid use of implicit any #2955
Draft
matthieusieben
wants to merge
17
commits into
msi/lex-gen-typefixes
Choose a base branch
from
msi/ts-implicit-any
base: msi/lex-gen-typefixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
from
November 15, 2024 08:10
cd21c47
to
aa2e346
Compare
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
from
November 15, 2024 08:40
aa2e346
to
92404af
Compare
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
from
November 15, 2024 09:54
3764dfd
to
8dbbe9f
Compare
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
2 times, most recently
from
November 15, 2024 10:09
9a2105d
to
4b30d56
Compare
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
2 times, most recently
from
November 15, 2024 10:50
fe5bb04
to
9117a3e
Compare
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
from
November 15, 2024 10:53
9117a3e
to
f3e9946
Compare
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
from
November 15, 2024 10:53
4b30d56
to
1d1d916
Compare
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
4 times, most recently
from
November 15, 2024 13:36
2e09700
to
c4b687d
Compare
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
3 times, most recently
from
November 15, 2024 14:21
a5e7c4f
to
0d774bc
Compare
matthieusieben
force-pushed
the
msi/ts-implicit-any
branch
from
December 2, 2024 15:42
0d774bc
to
9d07f1e
Compare
matthieusieben
force-pushed
the
msi/lex-gen-typefixes
branch
8 times, most recently
from
December 18, 2024 10:17
235b34d
to
ba0dfe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2999
Using
main
instead ofmsi/lex-gen-typefixes
(#2956) as "base branch" to allows CI to run.The tsconfig currently does not disable the use of "implicit any". This can have harmful side effects as this effectively disables type safety without a way of notifying the developer. This change fixes that.