Improve codegen bundle size and typings #2999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
3 times, most recently
from
2abd90e to
ef8af3f
Compare
matthieusieben
changed the title
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
2 times, most recently
from
bebca0e to
0bea135
Compare
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
0bea135 to
02ddb9a
Compare
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
02ddb9a to
1a337a2
Compare
rafaelbsky
approved these changes
Nov 18, 2024
devinivy
reviewed
Dec 2, 2024
packages/api/src/client/util.ts
Outdated
Comment on lines
21
to
25
| : // $type === `${id}#${hash}` | ||
| $type.length === id.length + 1 + hash.length && | ||
| $type[id.length] === '#' && | ||
| $type.startsWith(id) && | ||
| $type.endsWith(hash)) |
There was a problem hiding this comment.
For workloads where check$type() is usually true it's not clear to me that this is going to have the intended effect of a performance improvement over the simpler version. Or is the idea specifically to avoid allocating the additional string?
There was a problem hiding this comment.
Did it mainly for the string allocation. The optimization in the false case is a bonus.
https://jsbench.me/l6m46vgr4q/1
truecase is 4% fasterfalsecase is > 50% faster
tested on FF
devinivy
reviewed
Dec 2, 2024
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
2714235 to
617d86c
Compare
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
6e398be to
17b3081
Compare
devinivy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a 3 step changes aimed at improving typing in the atproto repo:
$typeproperty to records and user object typesNote
When reviewing, "codegen" commits can be ignored as they only contain generated code changes.