app.bsky: permit 100mb video uploads #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
approved these changes
Mar 3, 2025
bnewbold
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Technically "breaking" under lexicon evolution rules, but definitely 👍 to this specific situation.
I think blob sizes are one of the worst parts of Lexicon evolution rules. Maybe we should make it explicitly ok/expected to increase them over time? Or some kind of "soft limit" / "hard limit"? We don't need to design that right now though.
| @@ -10,7 +10,7 @@ | |||
| "video": { | |||
There was a problem hiding this comment.
I think we should put a description here noting what the maxSize used to be, and that it was increased.
There was a problem hiding this comment.
Good call, all set 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the video upload size limit from 50mb to 100mb in the
app.bsky.embed.videolexicon.Technically there is a minor compatibility issue at play here. The PDS validates blob sizes at write time, so a PDS with an old version of this lexicon may be incompatible with a client assuming it can upload a 100mb video. This is not expected to pose a major compatibility issue, partly because a. the PDS already de facto limits upload sizes it may accept, b. the user may choose to upload a smaller video (clients generally don't increase original video sizes), and c. PDS distributions are generally updated within a timely manner these days. Lowering the size limit, on the other hand, would be much more disruptive.