Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.bsky: permit 100mb video uploads #3602

Merged
merged 4 commits into from
Mar 3, 2025
Merged

app.bsky: permit 100mb video uploads #3602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20666ba
app.bsky: permit 100mb videos.
devinivy Mar 3, 2025
8ccca9b
codegen
devinivy Mar 3, 2025
56dad1c
changeset
devinivy Mar 3, 2025
2a2cb80
app.bsky: add description to video embed blob field.
devinivy Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/selfish-suns-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@atproto/api": patch
"@atproto/pds": patch
---

Permit 100mb video embeds.
3 changes: 2 additions & 1 deletion lexicons/app/bsky/embed/video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
"properties": {
"video": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put a description here noting what the maxSize used to be, and that it was increased.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, all set 👍

"type": "blob",
"description": "The mp4 video file. May be up to 100mb, formerly limited to 50mb.",
"accept": ["video/mp4"],
"maxSize": 50000000
"maxSize": 100000000
},
"captions": {
"type": "array",
Expand Down
4 changes: 3 additions & 1 deletion packages/api/src/client/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5693,8 +5693,10 @@ export const schemaDict = {
properties: {
video: {
type: 'blob',
description:
'The mp4 video file. May be up to 100mb, formerly limited to 50mb.',
accept: ['video/mp4'],
maxSize: 50000000,
maxSize: 100000000,
},
captions: {
type: 'array',
Expand Down
1 change: 1 addition & 0 deletions packages/api/src/client/types/app/bsky/embed/video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const id = 'app.bsky.embed.video'

export interface Main {
$type?: 'app.bsky.embed.video'
/** The mp4 video file. May be up to 100mb, formerly limited to 50mb. */
video: BlobRef
captions?: Caption[]
/** Alt text description of the video, for accessibility. */
Expand Down
4 changes: 3 additions & 1 deletion packages/bsky/src/lexicon/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5693,8 +5693,10 @@ export const schemaDict = {
properties: {
video: {
type: 'blob',
description:
'The mp4 video file. May be up to 100mb, formerly limited to 50mb.',
accept: ['video/mp4'],
maxSize: 50000000,
maxSize: 100000000,
},
captions: {
type: 'array',
Expand Down
1 change: 1 addition & 0 deletions packages/bsky/src/lexicon/types/app/bsky/embed/video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const id = 'app.bsky.embed.video'

export interface Main {
$type?: 'app.bsky.embed.video'
/** The mp4 video file. May be up to 100mb, formerly limited to 50mb. */
video: BlobRef
captions?: Caption[]
/** Alt text description of the video, for accessibility. */
Expand Down
4 changes: 3 additions & 1 deletion packages/ozone/src/lexicon/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5693,8 +5693,10 @@ export const schemaDict = {
properties: {
video: {
type: 'blob',
description:
'The mp4 video file. May be up to 100mb, formerly limited to 50mb.',
accept: ['video/mp4'],
maxSize: 50000000,
maxSize: 100000000,
},
captions: {
type: 'array',
Expand Down
1 change: 1 addition & 0 deletions packages/ozone/src/lexicon/types/app/bsky/embed/video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const id = 'app.bsky.embed.video'

export interface Main {
$type?: 'app.bsky.embed.video'
/** The mp4 video file. May be up to 100mb, formerly limited to 50mb. */
video: BlobRef
captions?: Caption[]
/** Alt text description of the video, for accessibility. */
Expand Down
4 changes: 3 additions & 1 deletion packages/pds/src/lexicon/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5693,8 +5693,10 @@ export const schemaDict = {
properties: {
video: {
type: 'blob',
description:
'The mp4 video file. May be up to 100mb, formerly limited to 50mb.',
accept: ['video/mp4'],
maxSize: 50000000,
maxSize: 100000000,
},
captions: {
type: 'array',
Expand Down
1 change: 1 addition & 0 deletions packages/pds/src/lexicon/types/app/bsky/embed/video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const id = 'app.bsky.embed.video'

export interface Main {
$type?: 'app.bsky.embed.video'
/** The mp4 video file. May be up to 100mb, formerly limited to 50mb. */
video: BlobRef
captions?: Caption[]
/** Alt text description of the video, for accessibility. */
Expand Down