Fix Profile link from drawer on Mobile Web #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Sep 12, 2023
|
I feel like this shouldnt work just glancing at the code. The web uses a single flat navigation system, and this approach puts two routes on with the same path. My guess is that either |
|
@pfrazee It did work but it was such a hack. I created a new solution that is also a hack but a little better hack in my opinion since it isolates the hack into 3 lines of code |
pfrazee
requested changes
Sep 13, 2023
estrattonbailey
added a commit
that referenced
this pull request
Sep 15, 2023
* origin: Fix Profile link from drawer on Mobile Web (#1437) add build:apk and apk config (#1454) update Bluesky PBLLC to PBC (Public Benefit Corporation) (#1453) wrap impersonation text (#1447) share mute list link with did not handle (#1438) Fix 651 Make followers and following button into a `<Link>` (#1429) 1.50 Remove accessibilityRole=button on dropdown mask, it causes issues on firefox (#1436) Add birth date gating to moderation settings (#1435) Paginate the PostThread to avoid rendering too many posts and crashing the app on large threads (#1432) fix theme flashing (#1417) Separate list deletion into chunks (close #1430) (#1431) Revert "Fix 1338 mark notifications read with timeout and on app state change (#1340)" (#1433) Bump @atproto/[email protected] (#1434) make sure click events on the emoji picker don't bubble up to the mask (#1427) Lytic analytics migration (#1428) add new api event proxy (#1400) composer: inhibit Cmd-Enter from inputting newline (#1421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following bugs on mobile web: