Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Japanese Display #2881

Closed
wants to merge 4 commits into from
Closed

Conversation

Hima-Zinn
Copy link
Contributor

@Hima-Zinn Hima-Zinn commented Feb 16, 2024

@tkusano @dolciss @oboenikui @noritada @middlingphys @hibiki
Please review if the changes are correct.

@hibiki
Copy link
Contributor

hibiki commented Feb 16, 2024

Thank you! +1 for merge.

@reindex-ot
Copy link

hi...ここはちょっと日本語で。
翻訳の管理の現状を見てここで管理するのは厳しいだろうと思ったため、「Crowdinを使って管理をしないですか?」と要望しました。この意見に賛成する方もいたので他にも賛成の方はレスポンスとかするかと良いでしょう。あと未翻訳箇所の翻訳の追加、修正をやったPRをしました。 #2961

Copy link
Contributor

@noritada noritada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりすみません!全体的に問題ないと思います。
改善レベルで1箇所だけコメントしました。

Sorry for my late review! Overall, I think everything is fine.
I made one comment on the level of improvement.

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@Hima-Zinn
Copy link
Contributor Author

hi...ここはちょっと日本語で。

翻訳の管理の現状を見てここで管理するのは厳しいだろうと思ったため、「Crowdinを使って管理をしないですか?」と要望しました。この意見に賛成する方もいたので他にも賛成の方はレスポンスとかするかと良いでしょう。あと未翻訳箇所の翻訳の追加、修正をやったPRをしました。 #2961

Thank you for taking the trouble to contact us.
I too think it is good to have translations in a manageable state.
From now on, it would be helpful if you could mentions the members of the translation team when you submit an issue, if possible.

Co-authored-by: Noritada Kobayashi <[email protected]>
@Hima-Zinn
Copy link
Contributor Author

This PR is closed as new translations are being added to #2961.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants