-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial feature gating and A/B testing integration #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Mar 6, 2024
@@ -177,6 +177,8 @@ | |||
"react-responsive": "^9.0.2", | |||
"rn-fetch-blob": "^0.12.0", | |||
"sentry-expo": "~7.0.1", | |||
"statsig-react": "^1.36.0", | |||
"statsig-react-native-expo": "^4.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one technically isn't used yet.
haileyok
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a proof of concept setup we plan to use for gated feature rollout and AB testing with Statsig.
Scope
This proof of concept is very limited:
The goal here is just to get something running and make sure the setup works end-to-end.
Details
I've chosen a slightly quirky approach. I want to preserve two constraints:
So the approach I'm going with is that we always use stale values from
localStorage
from the last run. This means that feature rollout settings (e.g. bumping the %) kicks in on the next page load rather than on the page load after it was done. So rollouts lag behind a bit, but the upside is the UI is always consistent and startup is fast.Statsig SDK already deals with
localStorage
for us, so no need to do something special.See code comments for more details.
statsig_v0.mov
Let's experiment with this approach and see if there are any downsides.
How to use this
You call
useGate('test_gate')
and it gives youfalse
(default) ortrue
.Gates can be created in the Statsig console.
Here's the toy code I used in the video above.