-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial feature gating and A/B testing integration #3122
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6878047
Add statsig dependency
gaearon f9334ea
Add SDK provider
gaearon 3cb62e5
Move to separate file, add tier and hashing
gaearon 630931e
Disable local storage for now
gaearon fd9c1d1
Add initial gate testing fixture
gaearon 3b0ac12
Fork for web just in case
gaearon ea0e0bf
More WIP
gaearon a0ed5dc
wip
gaearon 2b691e4
Prefer cache
gaearon e4ef30d
Rm test gate
gaearon 014eb23
Add shim on native
gaearon 850111e
Clarify
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import React from 'react' | ||
|
||
export function useGate(_gateName: string) { | ||
// Not enabled for native yet. | ||
return false | ||
} | ||
|
||
export function Provider({children}: {children: React.ReactNode}) { | ||
// Not enabled for native yet. | ||
return children | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import React from 'react' | ||
import {StatsigProvider, useGate as useStatsigGate} from 'statsig-react' | ||
import {useSession} from '../../state/session' | ||
import {sha256} from 'js-sha256' | ||
|
||
const statsigOptions = { | ||
environment: { | ||
tier: process.env.NODE_ENV === 'development' ? 'development' : 'production', | ||
}, | ||
// Don't block on waiting for network. The fetched config will kick in on next load. | ||
// This ensures the UI is always consistent and doesn't update mid-session. | ||
// Note this makes cold load (no local storage) and private mode return `false` for all gates. | ||
initTimeoutMs: 1, | ||
} | ||
|
||
export function useGate(gateName: string) { | ||
const {isLoading, value} = useStatsigGate(gateName) | ||
if (isLoading) { | ||
// This should not happen because of waitForInitialization={true}. | ||
console.error('Did not expected isLoading to ever be true.') | ||
} | ||
return value | ||
} | ||
|
||
function toStatsigUser(did: string | undefined) { | ||
let userID: string | undefined | ||
if (did) { | ||
userID = sha256(did) | ||
} | ||
return {userID} | ||
} | ||
|
||
export function Provider({children}: {children: React.ReactNode}) { | ||
const {currentAccount} = useSession() | ||
const currentStatsigUser = React.useMemo( | ||
() => toStatsigUser(currentAccount?.did), | ||
[currentAccount?.did], | ||
) | ||
return ( | ||
<StatsigProvider | ||
sdkKey="client-SXJakO39w9vIhl3D44u8UupyzFl4oZ2qPIkjwcvuPsV" | ||
mountKey={currentStatsigUser.userID} | ||
user={currentStatsigUser} | ||
// This isn't really blocking due to short initTimeoutMs above. | ||
// However, it ensures `isLoading` is always `false`. | ||
waitForInitialization={true} | ||
options={statsigOptions}> | ||
{children} | ||
</StatsigProvider> | ||
) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one technically isn't used yet.