Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ALF for post controls #3400

Merged
merged 17 commits into from
May 30, 2024
Merged

Use ALF for post controls #3400

merged 17 commits into from
May 30, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Apr 4, 2024 •
edited
Loading

Changes:

  • New icons!
  • New repost menu
    • Web: ALF <Menu>
    • Native: ALF <Dialog>
  • Hover states
  • Cleaned up sizes/padding/etc
Screenshot 2024-04-04 at 20 28 35 Screenshot 2024-04-04 at 20 28 49 Screenshot 2024-04-04 at 20 29 01 Screenshot 2024-04-04 at 20 29 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Old size New size Diff
6.34 MB 6.35 MB 5.05 KB (0.08%)

@mozzius mozzius marked this pull request as ready for review April 4, 2024 19:33
estrattonbailey
estrattonbailey reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one nit, gonna sketch out my thoughts in a doc to discuss

src/components/icons/Quote.tsx Outdated Show resolved Hide resolved
src/view/com/util/post-ctrls/RepostButton.tsx Outdated Show resolved Hide resolved
src/components/Button.tsx Outdated Show resolved Hide resolved
@haileyok
Copy link
Contributor

haileyok commented Apr 4, 2024

hell yea, this has been bothering me every time i go to repost, seeing that ugly round button 😭

@mozzius
Copy link
Member Author

mozzius commented Apr 4, 2024

also, are we happy with the hover state?

Screenshot 2024-04-04 at 21 56 06 Screenshot 2024-04-04 at 21 56 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Old size New size Diff
7.23 MB 7.23 MB 3.23 KB (0.04%)

@pfrazee
Copy link
Collaborator

pfrazee commented Apr 4, 2024

ios feed before after
CleanShot 2024-04-04 at 15 35 29@2x CleanShot 2024-04-04 at 15 26 01@2x
ios thread before after
CleanShot 2024-04-04 at 15 35 51@2x CleanShot 2024-04-04 at 15 27 12@2x
web feed before after
CleanShot 2024-04-04 at 15 32 03@2x CleanShot 2024-04-04 at 15 29 02@2x
web thread before after
CleanShot 2024-04-04 at 15 31 43@2x CleanShot 2024-04-04 at 15 29 30@2x

@pfrazee
Copy link
Collaborator

pfrazee commented Apr 4, 2024

Excited for this change, but you know Imma nitpick.

First two thoughts:

CleanShot 2024-04-04 at 15 38 28@2x

Also the icons seem slightly larger in general. I may need to see it on an actual device but my initial reaction was they seemed big.

@mozzius
Copy link
Member Author

mozzius commented Apr 4, 2024

Hmm, interesting that the spacing has all changed. I think this is from the padding needed for the hover state

@haileyok haileyok mentioned this pull request Apr 7, 2024
Closed
@mozzius mozzius force-pushed the samuel/post-ctrls branch from abaf743 to 5401e6c Compare April 23, 2024 16:17
@render Render
Copy link

render bot commented Apr 23, 2024

Your Render PR Server URL is https://social-app-pr-3400.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cojtu6821fec7394s4b0.

@mozzius mozzius force-pushed the samuel/post-ctrls branch from 33d4caa to 8a754f9 Compare May 29, 2024 12:03
@gaearon gaearon merged commit 165feed into main May 30, 2024
6 checks passed
@gaearon gaearon deleted the samuel/post-ctrls branch May 30, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrattonbailey estrattonbailey estrattonbailey left review comments

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
bot: fingerprint compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mozzius @haileyok @pfrazee @gaearon @estrattonbailey