[Session] V2 (V2) #3728
Closed
[Session] V2 (V2) #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3728.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-columf5jm4es73818350. |
|
gaearon
reviewed
Apr 30, 2024
src/lib/hooks/useAccountSwitcher.ts
Outdated
| clearCurrentAccount() // back user out to login | ||
| setTimeout(() => { | ||
| Toast.show(_(msg`Sorry! We need you to enter your password.`)) |
There was a problem hiding this comment.
In the context of the account switcher this feels a bit confusing because I get kicked to the PWI screen — not to the login screen. So the screen I see in front of me has no relation to entering the password.
There was a problem hiding this comment.
Oh yep, good catch, we're gonna need to update this to throw up the login screen (if we want the same functionality). This was set up before we added the PWI home screen.
Merged
gaearon
force-pushed
the
session/v2-entire
branch
12 times, most recently
from
ed5301a to
6a6bd50
Compare
gaearon
force-pushed
the
session/v2-entire
branch
5 times, most recently
from
1005e43 to
fcb6d68
Compare
gaearon
force-pushed
the
session/v2-entire
branch
4 times, most recently
from
6fb0523 to
7d2b711
Compare
This was referenced May 1, 2024
gaearon
force-pushed
the
session/v2-entire
branch
2 times, most recently
from
96081de to
2438e74
Compare
This was referenced May 2, 2024
|
Landed #3910 which was the last remaining bit. Phew! Thanks @estrattonbailey for all the work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.