[Session] Call persist handler directly

[gaearon]

Extracted from #3728.

This is a plain refactor, no change in functionality. We had a bunch of indirection that turned out to be unnecessary and that made it way harder to read what this code is actually doing. This removes the indirection.

Concretely, networkErrorCallback was always specified to be clearCurrentAccount, and persistSessionCallback was always specified to be upsertAccount. So this inlines those calls directly and removes the configurable parameters.

There are likely some fixes and simplifications we can do on top but let's get this in first.

Test Plan

This is a bit tricky to test because you need to trigger one of the conditions that get us into the persist handler. One of those is the initial update when resuming a session. So what I've done is:

• Disabled the localStorage persistence writing code
• Updated 2FA setting in another tab
• Refreshed current tab
• Observed that we start out with stale account info, and then the new one gets applied via this callback

You can also just read the code with whitespace off and verify it's a mechanical transformation.

[render]

Your Render PR Server URL is https://social-app-pr-3828.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-coq0cd6d3nmc7383aq1g.

[github-actions]

Old size	New size	Diff
6.85 MB	6.85 MB	-336 B (-0.00%)

---