Add alt text limit to image dialog #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
alt-text-limit - social-app PR #5611
Render
Destroyed
arcalinea
temporarily deployed
to
alt-text-limit - social-app PR #5611
Render
Destroyed
|
gaearon
reviewed
Oct 5, 2024
src/view/com/composer/GifAltText.tsx
Outdated
| }, [onSubmit, altText]) | ||
| const t = useTheme() | ||
| const {_, i18n} = useLingui() | ||
| const [altText, setAltText] = useState(altTextRef.current) |
There was a problem hiding this comment.
we shouldn’t read refs during render.
this might be ok but why are we using a ref here? isn’t this a controlled input anyway?
gaearon
reviewed
Oct 5, 2024
| onChange, | ||
| Portal, | ||
| }: Props): React.ReactNode => { | ||
| const altTextRef = React.useRef<string>(image.alt) |
There was a problem hiding this comment.
hm, another ref. i’m worrying about proliferation of refs — why are we adding them? they should only be used as escape hatches and i don’t yet see what we’re escaping from. generally adding them for normal data flow needs to have some kind of explanation so we don’t miss this in reviews.
gaearon
requested changes
Oct 5, 2024
|
example in gif dialog in 13d195a |
arcalinea
temporarily deployed
to
alt-text-limit - social-app PR #5611
Render
Destroyed
gaearon
approved these changes
Oct 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates alt text limit to 2k characters for both images and GIFs + updates the UI with our char counter.