Refactor post meta to return PostView #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2024
arcalinea
temporarily deployed
to
embed-others - social-app PR #5645
Render
Destroyed
|
estrattonbailey
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gonna stack a few little cleanups.
This first one removes the special
ComposerOptsQuotetype in favor of plainAppBskyFeedDefs.PostView. Themetareturned when resolving post records now also becomesAppBskyFeedDefs.PostView.In a follow-up, I'll change
metafor other links to also use normal views.Test Plan
Note that this is touching actual quote display — not just composer previews. Verify quoting different types of posts (no media, media, quote, external link, non-post record, gif, some combinations) still works. Both in the composer (where you should see a preview of what you're quoting) and after posting (there should be no regression in displaying quotes — both in the feed and in the individual posts). It would be good to check moderation has not regressed (blocks get applied etc).
I've noticed even in prod there are some existing issues (like quotes of starter packs not displaying anything inside the quoted post bubble). I expect that this refactor should neither make those better nor worse.