-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post time localization on Android #6742
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a1b368c
Fix post time localization on native
auroursa c451b7b
Fix timezone
auroursa f1ddbab
Merge branch 'bluesky-social:main' into post-time-native
auroursa f6336bf
Merge branch 'bluesky-social:main' into post-time-native
auroursa e6cfdd8
Revent time.ts
auroursa b8b15f6
Add time.android.ts
auroursa 74943c9
Add missing 'an' and 'ast'
auroursa ed276ab
Merge branch 'bluesky-social:main' into post-time-native
auroursa 9badf53
Revent PostThreadItem.tsx
auroursa 346ab50
Resolve duplicate versions in lockfile
auroursa 385b300
Move to time.native.ts
auroursa 03608a1
Merge branch 'main' into post-time-native
auroursa 91d15ad
Follow #7055 to upgrade intl-datetimeformat version
auroursa 7b489d3
Remove time.native.ts
auroursa abfdfac
Merge branch 'bluesky-social:main' into post-time-native
auroursa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4274,6 +4274,15 @@ | |
dependencies: | ||
tslib "2" | ||
|
||
"@formatjs/intl-datetimeformat@^6.17.1": | ||
version "6.17.1" | ||
resolved "https://registry.yarnpkg.com/@formatjs/intl-datetimeformat/-/intl-datetimeformat-6.17.1.tgz#d5e800891f9d79c8f1af1999f51db51f1384eca1" | ||
integrity sha512-a18NqRo6R73xpREuMZo8FqjO+LnYFDHoeoviTh5de4ebI46wqLSDgbAIKoceuWblTQt8bvCpJIwvKgLItea88Q== | ||
dependencies: | ||
"@formatjs/ecma402-abstract" "2.3.1" | ||
"@formatjs/intl-localematcher" "0.5.9" | ||
tslib "2" | ||
|
||
"@formatjs/[email protected]": | ||
version "1.8.7" | ||
resolved "https://registry.yarnpkg.com/@formatjs/intl-enumerator/-/intl-enumerator-1.8.7.tgz#3f004753333f80cc468ae34046bd8416772a0412" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just flagging we need to measure the startup time impact of this on a real android device. We've had pretty bad regressions in the past due to related changes.
Another thing we might want to consider is forking this block between iOS and Android. If this is really android-only, it would be good to avoid activating this on iOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually maybe you can move this import to
time.android.ts
? Since that's the only place that needs that API. I realize this makes it a bit inconsistent but it does avoid potentially regressing something on iOS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm not sure whether that would break the dynamic imports below. Do they rely on ordering?