Fix post time localization on Android #6742

auroursa · 2024-11-26T05:48:13Z

It seems that the post date localization on Android is handled differently from Web and iOS. In some cases, this may cause the date localization to not work properly on Android. Here are some examples:

Before

Japanese (Web)

Chinese (Web)

Android

Chinese	Japanese

For Chinese, this date format is like rolling back to English, so it needs to be changed. At the very least, it should match the date format used on the web. The example after the fix:

After

Android

Chinese	Japanese

surfdude29 · 2024-11-26T07:24:36Z

This looks like a great solution, nice work 👌 (although I say that as someone who can't code or build the app to test it out, of course 😅)

One quick question: I can't read either Japanese or Chinese, are the correct date formats really exactly the same in the two languages? I must admit I never would have guessed that was the case 🤷🏻‍♂️

auroursa · 2024-11-26T07:33:49Z

This looks like a great solution, nice work 👌 (although I say that as someone who can't code or build the app to test it out, of course 😅)

One quick question: I can't read either Japanese or Chinese, are the correct date formats really exactly the same in the two languages? I must admit I never would have guessed that was the case 🤷🏻‍♂️

At least in date formatting, they are exactly the same.

For the sake of caution, I would like to ask @tkusano to review this if possible.

tkusano · 2024-11-26T07:59:46Z

the screenshot attached as "After / Japanese (Android)" looks good to me.

auroursa · 2024-12-03T01:38:32Z

It also fixes the localization of timestamps for archived posts.

Chinese

Before	After

Japanese

Before	After

gaearon · 2024-12-03T02:29:30Z

src/lib/strings/time.ts

@@ -1,12 +1,36 @@
+import {DateTimeFormat} from '@formatjs/intl-datetimeformat'


We'd like to avoid importing something that isn't used on the web. Let's instead fork this file like time.ts vs time.web.ts and keep this import in the native version. This also lets you remove the inline checks.

In fact, maybe it's worth moving the code into time.android.ts if we're sure the fix is only needed there

gaearon

let's tweak to fork the file instead

auroursa · 2024-12-03T05:53:20Z

Reverted time.ts, and made the necessary changes to PostThreadItem.tsx

I believe the changes are only needed there for now, other time localizations seem fine.

src/view/com/post-thread/PostThreadItem.tsx

gaearon · 2024-12-07T02:10:19Z

yarn.lock

@@ -4258,6 +4258,31 @@
    "@formatjs/intl-localematcher" "0.5.4"
    tslib "^2.4.0"

+"@formatjs/[email protected]":


We have two copies of this in the lockfile now. I think we need to bump other related libraries in package.json so that we have everything in a lockstep and transitive dependencies are shared as much as possible.

gaearon · 2024-12-07T02:12:01Z

src/locale/i18n.ts

@@ -1,8 +1,10 @@
 // Don't remove -force from these because detection is VERY slow on low-end Android.
 // https://github.com/formatjs/formatjs/issues/4463#issuecomment-2176070577
 import '@formatjs/intl-locale/polyfill-force'
+import '@formatjs/intl-datetimeformat/polyfill-force'


Just flagging we need to measure the startup time impact of this on a real android device. We've had pretty bad regressions in the past due to related changes.

Another thing we might want to consider is forking this block between iOS and Android. If this is really android-only, it would be good to avoid activating this on iOS.

Actually maybe you can move this import to time.android.ts? Since that's the only place that needs that API. I realize this makes it a bit inconsistent but it does avoid potentially regressing something on iOS.

I guess I'm not sure whether that would break the dynamic imports below. Do they rely on ordering?

auroursa · 2024-12-07T02:45:44Z

I will test it on Android and iOS later and update the yarn.lock.

About performance issues, will simulate a low-performance Android device to verify its impact.

Not entirely sure whether to introduce this on iOS as well since the behavior on iOS currently seems consistent with the Web.

Needs conduct more detailed tests over the next few days to carefully ensure nothing breaks.

gaearon · 2024-12-07T03:04:49Z

I wonder what the source of discrepancy is. So far Android/iOS have been consistent with other i18n stuff.

auroursa · 2024-12-07T03:29:37Z

I wonder what the source of discrepancy is. So far Android/iOS have been consistent with other i18n stuff.

It seems that lingui has an issue when handling long-format dates, as this part is directly formatted through lingui.

Maybe I’ll create a minimal reproducible example to report this to upstream, as the issue consistently appears with both the previously used v4.5.0 and the latest v4.14.1 in RN 0.76. And it only affects certain asian languages on Android.

It’s quite challenging to find other RN projects that use lingui for time formatting. lingui appears to focus more on handling time formatting for the web, so that I switched to a time formatting method more commonly used in RN projects.

auroursa · 2024-12-07T13:10:20Z

Just a personal thought, maybe we could try having iOS format the time using DateTimeFormat as well. We could still maintain the i18n-related imports in one place, which might help avoid additional maintenance effort.

After cleaning the lockfile, I retested on both iOS and Android, and the time formatting works correctly on iOS as well. I haven’t done rigorous flame graph testing on performance yet, but there doesn’t seem to be a significant impact on the app’s startup time on a simulated low-end Android device.

auroursa · 2024-12-15T03:21:00Z

I submitted an issue with a minimal reproducible example to Lingui, and this is the response I received:

Lingui does not format dates by itself. It internally uses https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl.

If dates are not formatted correctly for you it's most likely because you need to set up the polyfill: https://lingui.dev/tutorials/react-native#polyfilling-intl-apis

Based on this I adjusted this PR. We still need to include intl-datetimeformat, but no longer need to fork time.ts.

timofei-iatsenko · 2024-12-16T08:49:55Z

FYI, you also might be interested in that PR (not merged yet) in the lingui lingui/js-lingui#2117

auroursa · 2024-12-16T11:47:13Z

FYI, you also might be interested in that PR (not merged yet) in the lingui lingui/js-lingui#2117

Thank you for pointing that out! 5.x also has some features that I'm particularly interested in, such as print placeholder values. I’ll check it again once it’s merged.

For now, I'd like to introduce polyfill to address the current issues, since it looks like migrating from 4.x to 5.x requires some changes beyond the scope of this PR. I admit I’ve been a bit eager to push this PR forward since it has been bothering me for some time.

Thanks again for clarifying my doubts so thoroughly!

gaearon

lets try this

gaearon · 2024-12-16T14:26:27Z

Unrelated to this PR but noticed the DM conversation screen doesn't seem to translate dates:

Wanna look into this?

auroursa · 2024-12-16T14:38:53Z

Wanna look into this?

Glad to look into this, but I’d like to learn more details. It seems to be working on Android when I tested. Does it happen when opening DM conversation after switching the language?

gaearon · 2024-12-16T14:41:42Z

Hmm it does happen for me. Note you have to scroll up a bit so that it shows dates.

auroursa · 2024-12-16T14:53:18Z

It hasn’t happened to me at this moment, but I have faced it before. Will look into it and see how to fix it when appropriate.

surfdude29 · 2024-12-16T18:28:02Z

Fwiw I see the DM issue too on iOS, e.g. here:

Co-authored-by: surfdude29 <[email protected]>

* main: (58 commits) Fix tests Layout tweaks (bluesky-social#7150) Trending (Beta) (bluesky-social#7144) Fix emoji picker position (bluesky-social#7146) Tweak Follow dialog Search placeholder (bluesky-social#7147) New progress guide - 10 follows (bluesky-social#7128) Pipe statsig events to logger (bluesky-social#7141) Fix notifications borders (bluesky-social#7140) Refetch empty feed on focus (bluesky-social#7139) Read storage on window.onstorage (bluesky-social#7137) [ELI5] Tweak wording on the signup screen (bluesky-social#7136) alf error screen (bluesky-social#7135) add safe area view to profile error screen (bluesky-social#7134) Adjust gates (bluesky-social#7132) disable automaticallAdjustsScrollIndicatorInsets (bluesky-social#7131) Bump more native deps (bluesky-social#7129) Update more Expo packages (bluesky-social#7127) feat: widen recent search profile link for mobile devices (bluesky-social#7119) Fix video uploads on native (bluesky-social#7126) Fix post time localization on Android (bluesky-social#6742) ... # Conflicts: # src/view/com/profile/ProfileSubpageHeader.tsx # src/view/screens/ProfileList.tsx

* Empty * First pass * More colloquial Romanian * Add Romanian lanaguage * Romanian specfic plural with 3 variants * Adjustments * Chat > Conversație * Keep code alphabetical order * Update messages.po * Add 'ro' to app.config.js * Regenerate and finish RO * Update messages.po * Fixing a previous wrong conflict resolution * Adapt after #6742 Co-authored-by: surfdude29 <[email protected]> --------- Co-authored-by: Alex <[email protected]> Co-authored-by: surfdude29 <[email protected]>

This reverts commit b1b6aff.

auroursa added 2 commits November 26, 2024 11:41

Fix post time localization on native

a1b368c

Fix timezone

c451b7b

Merge branch 'bluesky-social:main' into post-time-native

f1ddbab

gaearon reviewed Dec 3, 2024

View reviewed changes

gaearon requested changes Dec 3, 2024

View reviewed changes

auroursa added 3 commits December 3, 2024 13:28

Merge branch 'bluesky-social:main' into post-time-native

f6336bf

Revent time.ts

e6cfdd8

Add time.android.ts

b8b15f6

auroursa requested a review from gaearon December 3, 2024 05:53

This comment was marked as resolved.

Sign in to view

auroursa added 2 commits December 3, 2024 14:37

Add missing 'an' and 'ast'

74943c9

Merge branch 'bluesky-social:main' into post-time-native

ed276ab

gaearon reviewed Dec 7, 2024

View reviewed changes

src/view/com/post-thread/PostThreadItem.tsx Outdated Show resolved Hide resolved

Revent PostThreadItem.tsx

9badf53

gaearon reviewed Dec 7, 2024

View reviewed changes

auroursa added 2 commits December 7, 2024 20:53

Resolve duplicate versions in lockfile

346ab50

Move to time.native.ts

385b300

auroursa added 3 commits December 12, 2024 09:19

Merge branch 'main' into post-time-native

03608a1

Follow bluesky-social#7055 to upgrade intl-datetimeformat version

91d15ad

Remove time.native.ts

7b489d3

Merge branch 'bluesky-social:main' into post-time-native

abfdfac

gaearon approved these changes Dec 16, 2024

View reviewed changes

gaearon merged commit b1b6aff into bluesky-social:main Dec 16, 2024

This was referenced Dec 16, 2024

Romanian localization #6456

Merged

Add Greek Language ('el') Support and Internationalization #6677

Open

Add Khmer Localization #6914

Merged

Amharic translation #6618

Open

Add Portuguese-PT locale/translations support #6836

Draft

auroursa deleted the post-time-native branch December 17, 2024 02:38

claudiu-cristea added a commit to claudiu-cristea/social-app that referenced this pull request Dec 17, 2024

Adapt after bluesky-social#6742

0a50b93

Co-authored-by: surfdude29 <[email protected]>

estrattonbailey mentioned this pull request Dec 19, 2024

Date time format fix #7195

Closed

gaearon added a commit that referenced this pull request Dec 19, 2024

Revert "Fix post time localization on Android (#6742)"

51a47f3

This reverts commit b1b6aff.

gaearon mentioned this pull request Dec 19, 2024

Revert "Fix post time localization on Android" #7196

Merged

gaearon added a commit that referenced this pull request Dec 19, 2024

Revert "Fix post time localization on Android (#6742)" (#7196)

fb920f8

This reverts commit b1b6aff.

haileyok pushed a commit that referenced this pull request Dec 19, 2024

Revert "Fix post time localization on Android (#6742)" (#7196)

469ec17

This reverts commit b1b6aff.

haileyok pushed a commit that referenced this pull request Dec 19, 2024

Revert "Fix post time localization on Android (#6742)" (#7196)

9ca625c

This reverts commit b1b6aff.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix post time localization on Android #6742

Fix post time localization on Android #6742

auroursa commented Nov 26, 2024 •

edited

Loading

surfdude29 commented Nov 26, 2024

auroursa commented Nov 26, 2024

tkusano commented Nov 26, 2024

auroursa commented Dec 3, 2024

gaearon Dec 3, 2024

gaearon Dec 3, 2024

gaearon left a comment

auroursa commented Dec 3, 2024

This comment was marked as resolved.

gaearon Dec 7, 2024

gaearon Dec 7, 2024

gaearon Dec 7, 2024

gaearon Dec 7, 2024

auroursa commented Dec 7, 2024

gaearon commented Dec 7, 2024 •

edited

Loading

auroursa commented Dec 7, 2024 •

edited

Loading

auroursa commented Dec 7, 2024

auroursa commented Dec 15, 2024

timofei-iatsenko commented Dec 16, 2024

auroursa commented Dec 16, 2024

gaearon left a comment

gaearon commented Dec 16, 2024

auroursa commented Dec 16, 2024

gaearon commented Dec 16, 2024

auroursa commented Dec 16, 2024

surfdude29 commented Dec 16, 2024

		@@ -1,12 +1,36 @@
		import {DateTimeFormat} from '@formatjs/intl-datetimeformat'

Fix post time localization on Android #6742

Fix post time localization on Android #6742

Conversation

auroursa commented Nov 26, 2024 • edited Loading

Before

After

surfdude29 commented Nov 26, 2024

auroursa commented Nov 26, 2024

tkusano commented Nov 26, 2024

auroursa commented Dec 3, 2024

Chinese

Japanese

gaearon Dec 3, 2024

Choose a reason for hiding this comment

gaearon Dec 3, 2024

Choose a reason for hiding this comment

gaearon left a comment

Choose a reason for hiding this comment

auroursa commented Dec 3, 2024

This comment was marked as resolved.

gaearon Dec 7, 2024

Choose a reason for hiding this comment

gaearon Dec 7, 2024

Choose a reason for hiding this comment

gaearon Dec 7, 2024

Choose a reason for hiding this comment

gaearon Dec 7, 2024

Choose a reason for hiding this comment

auroursa commented Dec 7, 2024

gaearon commented Dec 7, 2024 • edited Loading

auroursa commented Dec 7, 2024 • edited Loading

auroursa commented Dec 7, 2024

auroursa commented Dec 15, 2024

timofei-iatsenko commented Dec 16, 2024

auroursa commented Dec 16, 2024

gaearon left a comment

Choose a reason for hiding this comment

gaearon commented Dec 16, 2024

auroursa commented Dec 16, 2024

gaearon commented Dec 16, 2024

auroursa commented Dec 16, 2024

surfdude29 commented Dec 16, 2024

auroursa commented Nov 26, 2024 •

edited

Loading

gaearon commented Dec 7, 2024 •

edited

Loading

auroursa commented Dec 7, 2024 •

edited

Loading