adds line number to tracing tag of python functions to make them unique #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 14, 2024
phiwuu
approved these changes
Jun 17, 2024
phiwuu
requested changes
Jun 26, 2024
| @@ -90,7 +90,11 @@ def fqn(self): | |||
| rv = self.parent.fqn() + "." | |||
| else: | |||
| rv = "" | |||
| rv += self.name | |||
| if self.location.line is not None and \ | |||
There was a problem hiding this comment.
Please consider the following refactoring:
- Call
self.fqnonce before creatingImplementation, seelobster/lobster/tools/python/python.py
Line 157 in 86cd606
- Find a unique name by iterating over
items - Don't use the line number, because this ID will be dynamic and changes if someone adds new lines to the file. Instead, use some kind of counter.
The first tag name shall always be without a number. Only the second tag name shall add a suffix.
christophkloeffel
force-pushed
the
patch/lobster-tool-python-duplicate-function
branch
from
86cd606 to
331529b
Compare
phiwuu
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: