[do not merge] (second attempt) apply scientific-python template to enable CI/CD #2
Conversation
Files updated using `end-of-file-fixer`, `mixed-line-ending`, `trailing-whitespace`, `blacken-docs` and `mirrors-prettier` pre-commit hooks
ebrahimebrahim
changed the title
| hooks: | ||
| - id: ruff | ||
| args: ["--fix", "--show-fixes"] | ||
| # - id: ruff-format # Omitting ruff-format for now |
There was a problem hiding this comment.
@jcfr Notice that I omit the ruff-format pre-commit hook. This is so that I don't have to put in the sweeping style changes that ruff-format brings about. A future commit could do this, but I kind of want to tone it down with the style changes for this. Does that seem reasonable?
This will make it possible to switch from setup.py to pyproject.toml in a shortly upcoming commit
ebrahimebrahim
force-pushed
the
do_python_packaging_and_ci_cd_take3
branch
from
e90e544 to
a1ae6cd
Compare
Adapt repo based on the cookiecutter at scientific-python/cookie@8c0a1627 This enables CI/CD, adds dependabot configuration, pre-commit configuration, and several other things.
ebrahimebrahim
force-pushed
the
do_python_packaging_and_ci_cd_take3
branch
from
a1ae6cd to
66e12a1
Compare
|
@jcfr Okay here is officially my second attempt at this! I took into account all the comments you left on my previous attempt. Please let me know if you think it looks good and I'll go make the actual PR. |
|
(@jcfr Oops I forgot you were ooo this week. I'm going to go ahead and make this PR on the main HD_BET repo to start soliciting feedback sooner rather than later -- I think this is already close to what we want based on our last discussion. Thanks!) |
This PR is not meant to be merged but just to help explore/discuss the changes needed to apply the scientific-python template to HD_BET. If successful, the actual PR will be on the original repository and not this fork.