forked from anycore/anycore-riscv-src
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dcache rr #7
Open
efraisse
wants to merge
19
commits into
bring-your-own-core:piton
Choose a base branch
from
vrobot:dcache_RR
base: piton
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dcache rr #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't work but I believe its progress?
…present conclusions
…ntroller, moving on to duplicating logic in the Dcache controller and then hopefully running some tests to see what works and doesnt
…o go, going to push these changes and make a pr to ask for help, also left some comments with questions
Note: Dcache does not work yet. Hello world gives a "good trap", but nothing gets printed (as one would expect with a broken data cache).
Note: DCache is still broken, but now it's less broken :)
Tested with rv64ui-p-sw.S (store word benchmark program): - Number of cache misses goes down from 10,052 to 9965 - Ensured that data is being stored in all 4 ways, not just the first way (indicating success in associativity) - All test cases pass (indicating that the cache is returning the correct data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some changes to dcache and was wondering if I could receive some more input about what logic I should duplicate or some other pointers before attempting to run the 4 way associative Icache. I believe the ICache changes are also present on this branch so I could easily compare and add logic.