Support App.tsx files in expo-cli #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add App.tsx to possible files to check
Add tests for App.tsx
yousif-bugsnag
force-pushed
the
PLAT-10157/expo-cli-app-tsx
branch
from
7acda1a to
c057a0d
Compare
Closed
gingerbenw
reviewed
Jan 10, 2025
packages/expo-cli/lib/test/fixtures/already-configured-ts-require/App.tsx
Outdated
Show resolved
Hide resolved
gingerbenw
reviewed
Jan 10, 2025
packages/expo-cli/lib/test/fixtures/already-configured-ts-import/App.tsx
Outdated
Show resolved
Hide resolved
yousif-bugsnag
force-pushed
the
PLAT-10157/expo-cli-app-tsx
branch
from
c057a0d to
d5393fc
Compare
gingerbenw
reviewed
Jan 13, 2025
gingerbenw
approved these changes
Jan 13, 2025
yousif-bugsnag
force-pushed
the
PLAT-10157/expo-cli-app-tsx
branch
from
e747e4d to
5511518
Compare
Co-authored-by: Ben Wilson <[email protected]>
yousif-bugsnag
force-pushed
the
PLAT-10157/expo-cli-app-tsx
branch
from
5511518 to
43984cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates the insert command in expo-cli to support projects with an
App.tsxfile - see #131 for the original PR by @KBirzins.Testing
Added new unit tests and associated fixtures