Fall back to using environment variables when os.hostname fails #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.0.1 added a simple guard around
os.hostname
to prevent a crash on Windows 7 - however the original library authors have correctly pointed out that this significantly increases the likelihood of collisions on Win 7 - paralleldrive#264 (comment)This is a port of @FlyingDR's PR on the original cuid library (paralleldrive#264) which improves that fix by attempting to fall back to environment variables when os.hostname fails.