Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapping exception in connect record id field #134

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

BoehmDo
Copy link
Contributor

@BoehmDo BoehmDo commented Oct 23, 2024

should fix #49,
replaced the parsing of the ID as an integer with getInt with the more flexible getString to account for arbitrary ID types

@BoehmDo BoehmDo requested a review from chgl October 23, 2024 20:10
Copy link

github-actions bot commented Oct 23, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.09s
✅ BASH bash-exec 4 0 0.08s
✅ BASH shellcheck 4 0 0.04s
✅ BASH shfmt 4 0 0.05s
✅ DOCKERFILE hadolint 1 0 0.16s
✅ EDITORCONFIG editorconfig-checker 128 0 0.85s
✅ GROOVY npm-groovy-lint 2 0 11.47s
✅ JAVA checkstyle 46 0 8.17s
✅ JSON jsonlint 18 0 0.19s
✅ JSON npm-package-json-lint yes no 0.69s
✅ JSON prettier 18 0 0.62s
✅ JSON v8r 18 0 39.56s
✅ MARKDOWN markdownlint 8 0 0.84s
✅ REPOSITORY checkov yes no 13.26s
✅ REPOSITORY gitleaks yes no 0.46s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 14.35s
✅ REPOSITORY kics yes no 14.94s
✅ REPOSITORY secretlint yes no 0.92s
✅ REPOSITORY syft yes no 2.55s
✅ REPOSITORY trivy yes no 7.54s
✅ REPOSITORY trivy-sbom yes no 1.28s
✅ REPOSITORY trufflehog yes no 5.85s
✅ XML xmllint 13 0 0.03s
✅ YAML prettier 16 0 0.99s
✅ YAML v8r 16 0 17.91s
✅ YAML yamllint 16 0 0.89s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link

Trivy image scan report

ghcr.io/bzkf/obds-to-fhir:pr-134 (debian 12.7)

No Vulnerabilities found

No Misconfigurations found

Java

6 known vulnerabilities found (CRITICAL: 0 HIGH: 4 MEDIUM: 2 LOW: 0)

Show detailed table of vulnerabilities
Package ID Severity Installed Version Fixed Version
ca.uhn.hapi.fhir:org.hl7.fhir.r4 CVE-2024-45294 HIGH 6.3.11 6.3.23
ca.uhn.hapi.fhir:org.hl7.fhir.utilities CVE-2024-45294 HIGH 6.3.11 6.3.23
commons-io:commons-io CVE-2024-47554 HIGH 2.11.0 2.14.0
org.springframework:spring-context CVE-2024-38820 MEDIUM 6.1.11 6.1.14, 6.0.25, 5.3.41
org.springframework:spring-web CVE-2024-38809 MEDIUM 6.1.11 5.3.38, 6.0.23, 6.1.12
org.springframework:spring-webmvc CVE-2024-38816 HIGH 6.1.11 6.1.13, 6.0.24, 5.3.40

No Misconfigurations found

Copy link

Code Coverage Report

Overall Project 88.49% 🍏
Files changed 100% 🍏

File Coverage
MeldungExport.java 89.47% 🍏

@chgl chgl merged commit a3f9d1e into master Oct 24, 2024
17 checks passed
@chgl chgl deleted the fix-mapping-exception-record-id branch October 24, 2024 11:37
miracum-bot pushed a commit that referenced this pull request Oct 24, 2024
## [2.3.0-beta.1](v2.2.1...v2.3.0-beta.1) (2024-10-24)

### Features

* first draft condition mapper ([#136](#136)) ([0e363e3](0e363e3))

### Bug Fixes

* mapping exception in connect record id field if it's not an integer ([#134](#134)) ([a3f9d1e](a3f9d1e))

### Miscellaneous Chores

* added dummy mapper classes and snapshot tests ([#133](#133)) ([d81dfda](d81dfda))
* added obds v3 skaffolding to beta ([#132](#132)) ([f805b2b](f805b2b)), closes [#101](#101)
* **deps:** update docker.io/gvenzl/oracle-free:23.5-slim-faststart docker digest to 9c0f4d5 ([#112](#112)) ([9db2691](9db2691))
* **deps:** update gcr.io/distroless/java21-debian12:nonroot docker digest to 2985410 ([#113](#113)) ([e338f6b](e338f6b))
* **deps:** update github-actions ([#114](#114)) ([59d30c7](59d30c7))
* **deps:** update github-actions ([#137](#137)) ([63fe5cc](63fe5cc))

### CI/CD

* release only on master or workflow_dispatch ([#135](#135)) ([e70141a](e70141a))
@miracum-bot
Copy link
Collaborator

🎉 This PR is included in version 2.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

miracum-bot pushed a commit that referenced this pull request Nov 19, 2024
## [2.2.2](v2.2.1...v2.2.2) (2024-11-19)

### Bug Fixes

* mapping exception in connect record id field if it's not an integer ([#134](#134)) ([a3f9d1e](a3f9d1e))

### Miscellaneous Chores

* **deps:** update docker.io/gvenzl/oracle-free:23.5-slim-faststart docker digest to 9c0f4d5 ([#112](#112)) ([9db2691](9db2691))
* **deps:** update gcr.io/distroless/java21-debian12:nonroot docker digest to 2985410 ([#113](#113)) ([e338f6b](e338f6b))
* **deps:** update github-actions ([#114](#114)) ([59d30c7](59d30c7))
* **deps:** update github-actions ([#137](#137)) ([63fe5cc](63fe5cc))
@miracum-bot
Copy link
Collaborator

🎉 This PR is included in version 2.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants