Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: multiple refacs in ConditionMapperTest #142

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

pcvolkmer
Copy link
Collaborator

There are three different refacs at once, each in its own commit:

  • Use @BeforeAll to get rid of the use of test class constructors
  • Changes to related ToDo statement: Use parameterized test
  • Add default date format for oBDS (dates) to align resulting FHIR date to midnight

This ensures that only the date part is used from oBDS and FHIR
resource dates will be aligned to midnight at given time zone.
@pcvolkmer pcvolkmer requested a review from chgl October 28, 2024 14:23
@chgl chgl merged commit 84abcfe into bzkf:beta Oct 28, 2024
15 checks passed
chgl added a commit that referenced this pull request Oct 28, 2024
@pcvolkmer pcvolkmer deleted the refac_conditionmappertest branch October 28, 2024 21:14
@miracum-bot
Copy link
Collaborator

🎉 This PR is included in version 2.3.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants