feat: support capture groups in Pat-ID convert #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also allows to run tests in random order |
chgl
approved these changes
Sep 3, 2024
miracum-bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## [2.2.0](v2.1.3...v2.2.0) (2024-09-04) ### Features * support capture groups in Pat-ID convert ([#92](#92)) ([91edc17](91edc17)) ### Bug Fixes * check if Pat-ID is reasonable value ([#90](#90)) ([812d57c](812d57c)) * check if value matches ICD10GM pattern ([#98](#98)) ([99d60ad](99d60ad)) * date conversion for oBDS 3.x ([#78](#78)) ([32cd649](32cd649)) * **deps:** update all non-major dependencies ([3934356](3934356)) * return timespan of all partial radiations ([#80](#80)) ([c73a4fd](c73a4fd)), closes [#79](#79) ### CI/CD * updated build workflow to create signed releases ([#82](#82)) ([346d157](346d157)) ### Miscellaneous Chores * **config:** dont release on refactor and only on deps chore ([#68](#68)) ([76e18ec](76e18ec)) * **deps:** update github-actions ([#81](#81)) ([b89f7fd](b89f7fd)) ### Documentation * added CONTRIBUTING and DEVELOPMENT md ([#100](#100)) ([ed52cef](ed52cef)) * added SECURITY.md ([343c5e3](343c5e3))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will convert Pat-ID by using capture groups:
G([0-9]{8})will convertG12345678to12345678G([0-9]{8})will convertG123456789to12345678G/([0-9]{4})-([0-9]{4})will convertG/1234-5678to12345678If pattern does not match, this will return Pat-ID as is:
([0-9]{8})will not convertG12345678and return it without change.More examples in UnitTests.
Without capture groups in RegExp,
convertId(String)will keep its old behaviour.