Re-enabled tracing for external project builds #140
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 01c9f0e, the tracing functionality was wrapped with an "project name guard" (if that is a real name) preventing it from running when embedded in another project:
However, this caused tracing to be disabled for any projects which include
cactus_rt
in CMake withFetchContent
as suggested in the README. This is IMO one of the best features ofcactus_rt
and I would love to have it back.This pull request reverts the "project name guard" around the tracing sources and protobuf folder include. I also included a status message indicating that tracing will also be built.
I assume this functionality was added because of ROS 2 support (very excited about that BTW!) since the tracing might interfere? If so, perhaps another option is to enable/disable the tracing based on the
ENABLE_ROS2
flag instead of the project name guard, making it configurable.